-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export the certwatcher package #1292
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
@vincepri @pwittrock is this something controller-runtime would be interested in? |
The code was originally proposed by @bison in 2d952ac — I don't see anything in there that particularly worries me to expose it as non-internal package. @alvaroaleman @DirectXMan12 thoughts? |
yeah sgtm (looking at the code makes me want to replace the mutex with a RW mutex though). |
Awesome, I was thinking this would be nice to be able to use this with the |
Consumers might want to react to externally-managed + rotated certificates, and the certwatcher package handles this, but it is an internal package. Could we consider exporting it?
The text was updated successfully, but these errors were encountered: