Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the certwatcher package #1292

Closed
ncdc opened this issue Dec 8, 2020 · 6 comments · Fixed by #1441
Closed

Export the certwatcher package #1292

ncdc opened this issue Dec 8, 2020 · 6 comments · Fixed by #1441

Comments

@ncdc
Copy link
Contributor

ncdc commented Dec 8, 2020

Consumers might want to react to externally-managed + rotated certificates, and the certwatcher package handles this, but it is an internal package. Could we consider exporting it?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2021
@christopherhein
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2021
@christopherhein
Copy link
Member

christopherhein commented Mar 16, 2021

@vincepri @pwittrock is this something controller-runtime would be interested in?

@vincepri
Copy link
Member

The code was originally proposed by @bison in 2d952ac — I don't see anything in there that particularly worries me to expose it as non-internal package.

@alvaroaleman @DirectXMan12 thoughts?

@alvaroaleman
Copy link
Member

yeah sgtm (looking at the code makes me want to replace the mutex with a RW mutex though).

@christopherhein
Copy link
Member

Awesome, I was thinking this would be nice to be able to use this with the Runnable interfaces in the manager you could configure reloading like we have with internal webhooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants