Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test that uses source.Channel #1368

Closed
alvaroaleman opened this issue Feb 3, 2021 · 0 comments · Fixed by #1373
Closed

Add integration test that uses source.Channel #1368

alvaroaleman opened this issue Feb 3, 2021 · 0 comments · Fixed by #1373

Comments

@alvaroaleman
Copy link
Member

alvaroaleman commented Feb 3, 2021 •
edited
Loading

We broke source.Channel entirely and didn't notice that until after a release. We should add an integration test that verifies that events written to a source.Channel trigger a reconciliation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add tests in controller that use source.Channel varshaprasad96/controller-runtime
1 participant
@alvaroaleman