circular dependency between writeResponse & writeAdmissionResponse

[henrysecond1]

Environment

• k8s version: v1.19.9 (on-prem)
• controller-runvime version: v0.8.2

Problem

I'm not sure when it actually happens, but we suffered from a very large stack trace log when admission errors occur.
When we investigate the log, we saw the two functions (writeResponse and writeAdmissionResponse) are repeatedly calling each other.

• https://github.com/kubernetes-sigs/controller-runtime/blob/v0.11.1/pkg/webhook/admission/http.go#L105
• https://github.com/kubernetes-sigs/controller-runtime/blob/v0.11.1/pkg/webhook/admission/http.go#L129

Could you tell me any suggestions to solve this problem?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[FillZpp]

/remove-lifecycle stale

[FillZpp]

@henrysecond1 It might be caused by the broken connection (e.g., broken pipe) with kube-apiserver, so that the encoder could never write the response into w io.Writer, and then it runs into endless circular calling.