SetControllerReference should allow overwriting the previous controller

[therealak12]

I want to change the controller of an object. The current implementation of SetControllerReference returns an error if the new owner is different than the previous one.

Adding a new method SetControllerReferenceOverwrite can be a solution.

[vincepri]

Changing the controller owner of an object is a very rare operation, which can also impact deletion flows in case of forward collection. I'd expect users to remove the older reference first, then set a new one in that case?

[therealak12]

Agree it won't be used that much, but for doing so I needed to duplicate some controller-runtime internal methods such as referSameObject and validateOwner into our code which wasn't so pleasant!

[troy0820]

/kind support

Would creating a function to remove the controller reference (RemoveControllerReference) (RemoveOwnerReference) be something as a compromise?

[troy0820]

PR merged for function RemoveOwnerReference in controllerutil that should help this use case.

[therealak12]

PR merged for function RemoveOwnerReference in controllerutil that should help this use case.

Thanks!