Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should support SetWatchErrorHandler #2395

Closed
qingwusunny opened this issue Jul 5, 2023 · 2 comments · Fixed by #2494
Closed

should support SetWatchErrorHandler #2395

qingwusunny opened this issue Jul 5, 2023 · 2 comments · Fixed by #2494
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qingwusunny
Copy link

client-go support SetWatchErrorHandler
controller-runtime should support SetWatchErrorHandler, dev can do something when watch failed
@troy0820
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2023
@troy0820 troy0820 mentioned this issue Sep 14, 2023
Merged
5 tasks
@troy0820
Copy link
Member

There is a WIP PR that I have up that would hopefully establish this as part of the sharedindexinformer that we create when creating a cache. Looking for early feedback from the maintainers and what impact that this would have going forward with compatibility, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ SetErrorWatchHandler on SharedIndexInformer troy0820/controller-runtime
3 participants
@troy0820 @k8s-ci-robot @qingwusunny