Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing return statement in the webhook admissions func (*Decoder).DecodeRaw #2429

Closed
lleshchi opened this issue Jul 28, 2023 · 2 comments · Fixed by #2433
Closed

Missing return statement in the webhook admissions func (*Decoder).DecodeRaw #2429

lleshchi opened this issue Jul 28, 2023 · 2 comments · Fixed by #2433
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lleshchi
Copy link
Contributor

Previously, this conditional for an unstructured object ended in a return statement as seen here.

As the function is currently written without a return, for an unstructured object which is successfully unmashalled, it will fall through to the subsequent lines and fail to decode due to this issue.
@lleshchi
Copy link
Contributor Author

@vincepri @2uasimojo

@vincepri
Copy link
Member

vincepri commented Aug 1, 2023

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 1, 2023
@lleshchi lleshchi mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Add missing return statement in the webhook admissions func lleshchi/controller-runtime
3 participants
@vincepri @k8s-ci-robot @lleshchi