Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RELEASE.md file has markdown links that aren't rendering correctly #2526

Closed
timflannagan opened this issue Oct 6, 2023 · 3 comments · Fixed by #2538
Closed

The RELEASE.md file has markdown links that aren't rendering correctly #2526

timflannagan opened this issue Oct 6, 2023 · 3 comments · Fixed by #2538
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@timflannagan
Copy link

The root RELEASE.md currently has broken links in the "Now, let's generate the changelog" header. See https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md#now-lets-generate-the-changelog for a concrete reference.

@timflannagan
Copy link
Author

I'm not sure if this repository has a "good first issue" label, but this would qualify. Happy to fix this too.

@troy0820
Copy link
Member

troy0820 commented Oct 6, 2023

Are you seeing 404 errors or the anchor not going to the correct place? Clicking that brings me to the page and the section.

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Oct 6, 2023
@timflannagan
Copy link
Author

I'm seeing the "kubebuilder-release-tools" and "here" anchors aren't rendering correctly for me:

Create the changelog from the new branch release-<MAJOR.MINOR> (git checkout release-<MAJOR.MINOR>). You will need to use the [kubebuilder-release-tools][kubebuilder-release-tools] to generate the notes. See [here][release-notes-generation]

Screenshot 2023-10-06 at 12 26 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
3 participants