Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding opts for WatchFunc in informers #2737

Open
ccding opened this issue Mar 27, 2024 · 2 comments
Open

adding opts for WatchFunc in informers #2737

ccding opened this issue Mar 27, 2024 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ccding
Copy link

ccding commented Mar 27, 2024

I used kubebuilder to create an operator framework and wanted to modify TimeoutSeconds in the listerwatcher of informers. I dug into the controller-runtime code and found we should set TimeoutSeconds in this line of code

return listWatcher.WatchFunc(opts)

However, I didn't figure out if there was a way to pass a config in. Does anyone happen to know if there is a workaround?

@ccding
Copy link
Author

ccding commented Mar 27, 2024

I created a PR: #2738

please let me know if there is any issues. Thanks

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants