Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Webhook builder allows passing in more than one For type which gets overridden by the last type. #2739

Closed
troy0820 opened this issue Mar 27, 2024 · 0 comments · Fixed by #2740
Closed

🐛 Webhook builder allows passing in more than one For type which gets overridden by the last type. #2739

troy0820 opened this issue Mar 27, 2024 · 0 comments · Fixed by #2740
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@troy0820
Copy link
Member

This issue is in reference to this issue #1173.

I realized that this was being done within the reconciler builder but not the webhook. To enforce a sense of consistency, and error to the caller when this happens within the webhook builder as well.

/kind bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Return error if more than one For() is used on webhook builder troy0820/controller-runtime
2 participants
@troy0820 @k8s-ci-robot