Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic version is incorrect for setup-envtest #2795

Closed
mlhamel opened this issue Apr 22, 2024 · 3 comments
Closed

Semantic version is incorrect for setup-envtest #2795

mlhamel opened this issue Apr 22, 2024 · 3 comments

Comments

@mlhamel
Copy link

mlhamel commented Apr 22, 2024

For setup-envtest there's a change that introduced at 4c2442e but it seems the version of was changed to 1.22.0 but it doesn't follow semantic versioning and crash while updating packages:

It should be 1.22 at https://github.com/kubernetes-sigs/controller-runtime/blob/main/tools/setup-envtest/go.mod#L3

@mlhamel mlhamel changed the title Semantic version of is incorrect for setup-envtest Semantic version is incorrect for setup-envtest Apr 22, 2024
@sbueringer
Copy link
Member

There have been a few issues and PRs about this before.

The tldr is, no the format is correct. Please either use Go 1.22 or pin setup envtest to release-0.17

@mlhamel
Copy link
Author

mlhamel commented Apr 23, 2024

thanks @sbueringer, i'm closing the issue cause yeah it seems the issue was on my end.

@mlhamel mlhamel closed this as completed Apr 23, 2024
@sbueringer
Copy link
Member

It doesn't help that some Go versions are returning wrong error messages :) (i.e. that the version should be major.minor instead of major.minor.patch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants