Incorrect patch generated with jsonpatch

[com6056]

I am encountering an issue when trying to inject things into pods with more than 1 container.

The ReplicaSet returns Error creating: Internal error occurred: Internal error occurred: Unable to remove invalid index: 1. I've narrowed it down to an issue with jsonpatch.

The issue is outlined here: mattbaird/jsonpatch#7
This fork has the fixes: https://github.com/appscode/jsonpatch

As a note, in the fork JsonPatchOperation is now just Operation.

[mengqiy]

Thanks for pointing this out!
We are considering switching to appscode/jsonpatch.

As a note, in the fork JsonPatchOperation is now just Operation.

This is a breaking change. We probably will switch to appscode/jsonpatch in v0.2.0 if we plan to introduce it as is.

[rajathagasthya]

@mengqiy (tangential) Just curious why https://github.com/evanphx/json-patch isn't used here. It's used in k/k.

[mengqiy]

@rajathagasthya https://github.com/evanphx/json-patch supports json patch (only applying patch) and json merge patch (generating and applying patch); while mattbaird/jsonpatch supports json patch (generating and applying patch)

Generating means: given 2 json objects and return the patch in byte array format.
Applying means: given a patch in byte array format, applying the changes to a json object.