Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllerutil: SetControllerReference does not allow disabling BlockOwnerDeletion #2846

Closed
muwaqar opened this issue Jun 5, 2024 · 0 comments · Fixed by #2847
Closed

controllerutil: SetControllerReference does not allow disabling BlockOwnerDeletion #2846

muwaqar opened this issue Jun 5, 2024 · 0 comments · Fixed by #2847

Comments

@muwaqar
Copy link
Contributor

muwaqar commented Jun 5, 2024

controllerutil SetControllerReference() implementation necessarily sets BlockOwnerDeletion = ptr.To(true). This means that the user needs to explicitly delete the referent resource before the owner can be cleaned up (see foreground deletion details).

users should be able to configure BlockOwnerDeletion while using these utility methods conveniently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@muwaqar