✨ Adds a client that enables strict field validation by default. #2860
+346
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
dlipovetsky
commented
Jun 20, 2024
|
|
||
| // testFieldValidationClient is a helper function that checks if calls have the expected field validation, | ||
| // and calls the callback function on each intercepted call. | ||
| func testFieldValidationClient(t *testing.T, expectedFieldValidation string, callback func()) client.Client { |
There was a problem hiding this comment.
I've shamelessly copied and adapted the test code from fieldowner_test.go.
This is almost identical to the testClient helper function in that file. I would be happy to refactor the two helper functions into one that can be used by both tests. I just think it's wise to copy first, and refactor second.
alvaroaleman
added
the
tide/merge-method-squash
alvaroaleman
approved these changes
Jun 29, 2024
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 99ddc4de5b300e2bff68e5eb57ae88a950f5e476
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows our users to enable strict field validation by default for all create, update, and patch requests.
The client can be used in a similar way to the specialized fieldManager-configuring client added in #2771.
Fixes #2859