Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tweaking client options a bit #388

Closed
DirectXMan12 opened this issue Apr 8, 2019 · 3 comments
Closed

Consider tweaking client options a bit #388

DirectXMan12 opened this issue Apr 8, 2019 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@DirectXMan12
Copy link
Contributor

I believe (been mulling this over a bit) that we can make it so that client options don't require different functions when the same option occurs, but the trade-offs are a bit strange in terms of compatibility. TL;DR is that we define an interface to accept as options instead of functions, and then structs can implement multiple different interfaces.

The downside is that the options functions now return a concrete type, which means that type is now part of the public interface, despite being a bit of an implementation detail. The alternative is returning an umbrella-interface, but that means that every time we add an element, it's a breaking change (since the function signature changes).

@DirectXMan12
Copy link
Contributor Author

/kind feature
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 8, 2019
@DirectXMan12 DirectXMan12 added this to the 1.0.0 milestone Apr 8, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2019
@DirectXMan12 DirectXMan12 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2019
@DirectXMan12
Copy link
Contributor Author

closing, fixed in #536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants