Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 broken in webhook server in v0.2.0-alpha.0 #408

Closed
lmunro-at-shopify opened this issue Apr 25, 2019 · 0 comments · Fixed by #409
Closed

HTTP2 broken in webhook server in v0.2.0-alpha.0 #408

lmunro-at-shopify opened this issue Apr 25, 2019 · 0 comments · Fixed by #409

Comments

@lmunro-at-shopify
Copy link
Contributor

The rework of the certificate generation seems to have removed support for HTTP2 as a side effect.

We now call http.Server.Serve instead of the old ListenAndServeTLS:

err = srv.Serve(listener)

Serve does not default to http2. It must be configured manually in the listener:

// HTTP/2 support is only enabled if the Listener returns *tls.Conn
// connections and they were configured with "h2" in the TLS
// Config.NextProtos.
//

It should be a small thing to fix.
I am going to submit a PR if can just get though signing the CLA, unless someone tells me this works as designed, in which case it should probably be mentioned somewhere in the release notes.

@lmunro-at-shopify lmunro-at-shopify changed the title HTTP2 broken in v0.2.0-alpha.0 HTTP2 broken in webhook server in v0.2.0-alpha.0 Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant