Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager.GetClient: Return different error than 404 when manager wasn't started #623

Closed
alvaroaleman opened this issue Oct 2, 2019 · 1 comment · Fixed by #627
Closed

manager.GetClient: Return different error than 404 when manager wasn't started #623

alvaroaleman opened this issue Oct 2, 2019 · 1 comment · Fixed by #627
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alvaroaleman
Copy link
Member

When the client returned by mgr.GetClient is being used for read operations before the mgr was startet, it returns 404 for all objects.

It would be a lot nicer if it instead returned an error indicating that it can't be used yet, because the mgr needs to be started first.
@alvaroaleman alvaroaleman mentioned this issue Oct 5, 2019
Merged
@DirectXMan12
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Return error when trying to read from an unstarted cache alvaroaleman/controller-runtime
3 participants
@DirectXMan12 @alvaroaleman @k8s-ci-robot