Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ResyncPeriod func in case of multi controllers list simultaneously #648

Closed
xrmzju opened this issue Oct 17, 2019 · 5 comments · Fixed by #647
Closed

use ResyncPeriod func in case of multi controllers list simultaneously #648

xrmzju opened this issue Oct 17, 2019 · 5 comments · Fixed by #647

Comments

@xrmzju
Copy link
Member

xrmzju commented Oct 17, 2019

like kube-controller-manger do

@DirectXMan12
Copy link
Contributor

We generally recommend not touching resync period (because it often doesn't do what you think it does), and using ResyncAfter or something else if you really need periodic behavior

@DirectXMan12
Copy link
Contributor

(closing for now, feel free to keep commenting)

@xrmzju
Copy link
Member Author

xrmzju commented Oct 18, 2019

@DirectXMan12 Sorry, I may not express myself clearly. my point is the default behaviour of controller-runtime for now is all reflectors will do resync action simutaneourly, which means multiple controllers may all hammer the apiserver with list requestes.

@DirectXMan12
Copy link
Contributor

Ok, so to summarize -- this is about adding jitter to the resync interval?

@DirectXMan12
Copy link
Contributor

I think that seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants