diff --git a/hack/test-all.sh b/hack/test-all.sh index 223b35689c..f92452164d 100755 --- a/hack/test-all.sh +++ b/hack/test-all.sh @@ -23,3 +23,7 @@ setup_envs header_text "running go test" go test -race ${MOD_OPT} ./... + +if [[ -n ${ARTIFACTS:-} ]]; then + if grep -Rin '' ${ARTIFACTS}/*; then exit 1; fi +fi diff --git a/pkg/builder/builder_suite_test.go b/pkg/builder/builder_suite_test.go index 3787cc6835..bee5a373a8 100644 --- a/pkg/builder/builder_suite_test.go +++ b/pkg/builder/builder_suite_test.go @@ -38,7 +38,8 @@ import ( func TestBuilder(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "application Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "application Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/cache/cache_suite_test.go b/pkg/cache/cache_suite_test.go index da5da22a84..dd32664f2a 100644 --- a/pkg/cache/cache_suite_test.go +++ b/pkg/cache/cache_suite_test.go @@ -31,7 +31,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Cache Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Cache Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/client/apiutil/apiutil_suite_test.go b/pkg/client/apiutil/apiutil_suite_test.go index cb232cbceb..9a4393d081 100644 --- a/pkg/client/apiutil/apiutil_suite_test.go +++ b/pkg/client/apiutil/apiutil_suite_test.go @@ -30,7 +30,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "API Utilities Test Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "API Utilities Test Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var cfg *rest.Config diff --git a/pkg/client/client_suite_test.go b/pkg/client/client_suite_test.go index 3634c13b73..0853bfac5f 100644 --- a/pkg/client/client_suite_test.go +++ b/pkg/client/client_suite_test.go @@ -32,7 +32,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Client Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/client/config/config_suite_test.go b/pkg/client/config/config_suite_test.go index 0a819a3962..7a4b8759e5 100644 --- a/pkg/client/config/config_suite_test.go +++ b/pkg/client/config/config_suite_test.go @@ -29,7 +29,8 @@ import ( func TestConfig(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Client Config Test Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Client Config Test Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func(done Done) { diff --git a/pkg/client/fake/client_suite_test.go b/pkg/client/fake/client_suite_test.go index 5a9db7ad32..434e34a4f6 100644 --- a/pkg/client/fake/client_suite_test.go +++ b/pkg/client/fake/client_suite_test.go @@ -29,7 +29,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Fake client Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func(done Done) { diff --git a/pkg/controller/controller_suite_test.go b/pkg/controller/controller_suite_test.go index e06a31ec92..53ab41f4bf 100644 --- a/pkg/controller/controller_suite_test.go +++ b/pkg/controller/controller_suite_test.go @@ -37,7 +37,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Controller Integration Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/controller/controllerutil/controllerutil_suite_test.go b/pkg/controller/controllerutil/controllerutil_suite_test.go index 248316eaa7..0cfd6d1e02 100644 --- a/pkg/controller/controllerutil/controllerutil_suite_test.go +++ b/pkg/controller/controllerutil/controllerutil_suite_test.go @@ -25,11 +25,13 @@ import ( "k8s.io/client-go/rest" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/envtest" + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" ) func TestControllerutil(t *testing.T) { RegisterFailHandler(Fail) - RunSpecs(t, "Controllerutil Suite") + suiteName := "Controllerutil Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var t *envtest.Environment diff --git a/pkg/envtest/envtest_suite_test.go b/pkg/envtest/envtest_suite_test.go index 3c2278c092..7a65400131 100644 --- a/pkg/envtest/envtest_suite_test.go +++ b/pkg/envtest/envtest_suite_test.go @@ -25,13 +25,15 @@ import ( admissionv1beta1 "k8s.io/api/admissionregistration/v1beta1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" logf "sigs.k8s.io/controller-runtime/pkg/log" "sigs.k8s.io/controller-runtime/pkg/log/zap" ) func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "EnvTest Suite", []Reporter{NewlineReporter{}}) + suiteName := "Envtest Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var env *Environment diff --git a/pkg/envtest/printer/prow.go b/pkg/envtest/printer/prow.go new file mode 100644 index 0000000000..5a586b3250 --- /dev/null +++ b/pkg/envtest/printer/prow.go @@ -0,0 +1,109 @@ +/* +Copyright 2020 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package printer + +import ( + "fmt" + "os" + "path/filepath" + "sync" + + "github.com/onsi/ginkgo" + "github.com/onsi/ginkgo/config" + "github.com/onsi/ginkgo/reporters" + "github.com/onsi/ginkgo/types" + + "k8s.io/apimachinery/pkg/util/sets" +) + +var ( + allRegisteredSuites = sets.String{} + allRegisteredSuitesLock = &sync.Mutex{} +) + +type prowReporter struct { + junitReporter *reporters.JUnitReporter +} + +// NewProwReporter returns a prowReporter that will write out junit if running in Prow and do +// nothing otherwise. +// WARNING: It seems this does not always properly fail the test runs when there are failures, +// see https://github.com/onsi/ginkgo/issues/706 +// When using this you must make sure to grep for failures in your junit xmls and fail the run +// if there are any. +func NewProwReporter(suiteName string) ginkgo.Reporter { + allRegisteredSuitesLock.Lock() + if allRegisteredSuites.Has(suiteName) { + panic(fmt.Sprintf("Suite named %q registered more than once", suiteName)) + } + allRegisteredSuites.Insert(suiteName) + allRegisteredSuitesLock.Unlock() + + if os.Getenv("CI") == "" { + return &prowReporter{} + } + artifactsDir := os.Getenv("ARTIFACTS") + if artifactsDir == "" { + return &prowReporter{} + } + + path := filepath.Join(artifactsDir, fmt.Sprintf("junit_%s_%d.xml", suiteName, config.GinkgoConfig.ParallelNode)) + return &prowReporter{ + junitReporter: reporters.NewJUnitReporter(path), + } +} + +func (pr *prowReporter) SpecSuiteWillBegin(config config.GinkgoConfigType, summary *types.SuiteSummary) { + if pr.junitReporter != nil { + pr.junitReporter.SpecSuiteWillBegin(config, summary) + } +} + +// BeforeSuiteDidRun implements ginkgo.Reporter +func (pr *prowReporter) BeforeSuiteDidRun(setupSummary *types.SetupSummary) { + if pr.junitReporter != nil { + pr.junitReporter.BeforeSuiteDidRun(setupSummary) + } +} + +// AfterSuiteDidRun implements ginkgo.Reporter +func (pr *prowReporter) AfterSuiteDidRun(setupSummary *types.SetupSummary) { + if pr.junitReporter != nil { + pr.junitReporter.AfterSuiteDidRun(setupSummary) + } +} + +// SpecWillRun implements ginkgo.Reporter +func (pr *prowReporter) SpecWillRun(specSummary *types.SpecSummary) { + if pr.junitReporter != nil { + pr.junitReporter.SpecWillRun(specSummary) + } +} + +// SpecDidComplete implements ginkgo.Reporter +func (pr *prowReporter) SpecDidComplete(specSummary *types.SpecSummary) { + if pr.junitReporter != nil { + pr.junitReporter.SpecDidComplete(specSummary) + } +} + +// SpecSuiteDidEnd Prints a newline between "35 Passed | 0 Failed | 0 Pending | 0 Skipped" and "--- PASS:" +func (pr *prowReporter) SpecSuiteDidEnd(summary *types.SuiteSummary) { + if pr.junitReporter != nil { + pr.junitReporter.SpecSuiteDidEnd(summary) + } +} diff --git a/pkg/handler/eventhandler_suite_test.go b/pkg/handler/eventhandler_suite_test.go index 67b2064a6b..5854226d68 100644 --- a/pkg/handler/eventhandler_suite_test.go +++ b/pkg/handler/eventhandler_suite_test.go @@ -30,7 +30,8 @@ import ( func TestEventhandler(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Eventhandler Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Eventhandler Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/healthz/healthz_suite_test.go b/pkg/healthz/healthz_suite_test.go index 1fcd3dd039..d871c010d3 100644 --- a/pkg/healthz/healthz_suite_test.go +++ b/pkg/healthz/healthz_suite_test.go @@ -28,7 +28,8 @@ import ( func TestHealthz(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Healthz Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Healthz Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func() { diff --git a/pkg/internal/controller/controller_suite_test.go b/pkg/internal/controller/controller_suite_test.go index 320c930922..8e4e23c8d0 100644 --- a/pkg/internal/controller/controller_suite_test.go +++ b/pkg/internal/controller/controller_suite_test.go @@ -31,7 +31,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Controller internal Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/internal/recorder/recorder_suite_test.go b/pkg/internal/recorder/recorder_suite_test.go index 75a2a083f2..b68536e2ff 100644 --- a/pkg/internal/recorder/recorder_suite_test.go +++ b/pkg/internal/recorder/recorder_suite_test.go @@ -31,7 +31,8 @@ import ( func TestRecorder(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Recorder Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Recorder Integration Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/internal/testing/integration/addr/addr_suite_test.go b/pkg/internal/testing/integration/addr/addr_suite_test.go index 2c7fbca879..a2502727b8 100644 --- a/pkg/internal/testing/integration/addr/addr_suite_test.go +++ b/pkg/internal/testing/integration/addr/addr_suite_test.go @@ -1,14 +1,17 @@ package addr_test import ( + "testing" + . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" - "testing" + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" ) func TestAddr(t *testing.T) { t.Parallel() RegisterFailHandler(Fail) - RunSpecs(t, "Addr Suite") + suiteName := "Addr Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/internal/testing/integration/integration_suite_test.go b/pkg/internal/testing/integration/integration_suite_test.go index 65e45f9951..446ea35796 100644 --- a/pkg/internal/testing/integration/integration_suite_test.go +++ b/pkg/internal/testing/integration/integration_suite_test.go @@ -1,14 +1,17 @@ package integration_test import ( + "testing" + . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" - "testing" + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" ) func TestIntegration(t *testing.T) { t.Parallel() RegisterFailHandler(Fail) - RunSpecs(t, "Integration Framework Unit Tests") + suiteName := "Integration Framework Unit Tests" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/internal/testing/integration/internal/integration_tests/integration_suite_test.go b/pkg/internal/testing/integration/internal/integration_tests/integration_suite_test.go index 07ca7d2b67..011b3e5609 100644 --- a/pkg/internal/testing/integration/internal/integration_tests/integration_suite_test.go +++ b/pkg/internal/testing/integration/internal/integration_tests/integration_suite_test.go @@ -1,14 +1,17 @@ package integrationtests import ( + "testing" + . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" - "testing" + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" ) func TestIntegration(t *testing.T) { t.Parallel() RegisterFailHandler(Fail) - RunSpecs(t, "Integration Framework Integration Tests") + suiteName := "Integration Framework Integration Tests" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/internal/testing/integration/internal/internal_suite_test.go b/pkg/internal/testing/integration/internal/internal_suite_test.go index d673cc4c97..358570b9db 100644 --- a/pkg/internal/testing/integration/internal/internal_suite_test.go +++ b/pkg/internal/testing/integration/internal/internal_suite_test.go @@ -1,14 +1,17 @@ package internal_test import ( + "testing" + . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" - "testing" + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" ) func TestInternal(t *testing.T) { t.Parallel() RegisterFailHandler(Fail) - RunSpecs(t, "Internal Suite") + suiteName := "Internal Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/log/log_suite_test.go b/pkg/log/log_suite_test.go index 3fb749caca..bf8e967cb7 100644 --- a/pkg/log/log_suite_test.go +++ b/pkg/log/log_suite_test.go @@ -26,5 +26,6 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Log Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Log Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/log/zap/zap_suite_test.go b/pkg/log/zap/zap_suite_test.go index 711ea0ae17..43044d8066 100644 --- a/pkg/log/zap/zap_suite_test.go +++ b/pkg/log/zap/zap_suite_test.go @@ -26,5 +26,6 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Zap Log Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Zap Log Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/manager/manager_suite_test.go b/pkg/manager/manager_suite_test.go index 8a79f7da5e..196902426e 100644 --- a/pkg/manager/manager_suite_test.go +++ b/pkg/manager/manager_suite_test.go @@ -32,7 +32,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Manager Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/manager/signals/signals_suite_test.go b/pkg/manager/signals/signals_suite_test.go index 4a691caa20..770df0ca9c 100644 --- a/pkg/manager/signals/signals_suite_test.go +++ b/pkg/manager/signals/signals_suite_test.go @@ -27,7 +27,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Runtime Signal Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Runtime Signal Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func() { diff --git a/pkg/predicate/predicate_suite_test.go b/pkg/predicate/predicate_suite_test.go index 6999dedcfe..2973526673 100644 --- a/pkg/predicate/predicate_suite_test.go +++ b/pkg/predicate/predicate_suite_test.go @@ -28,7 +28,8 @@ import ( func TestPredicate(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Predicate Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Predicate Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func() { diff --git a/pkg/reconcile/reconcile_suite_test.go b/pkg/reconcile/reconcile_suite_test.go index bf1ee571c0..08110df159 100644 --- a/pkg/reconcile/reconcile_suite_test.go +++ b/pkg/reconcile/reconcile_suite_test.go @@ -28,7 +28,8 @@ import ( func TestReconcile(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "reconcile Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Reconcile Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func() { diff --git a/pkg/runtime/inject/inject_suite_test.go b/pkg/runtime/inject/inject_suite_test.go index 8854ed33c8..98cf79ab3b 100644 --- a/pkg/runtime/inject/inject_suite_test.go +++ b/pkg/runtime/inject/inject_suite_test.go @@ -26,5 +26,6 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Runtime Injection Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Runtime Injection Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/scheme/scheme_suite_test.go b/pkg/scheme/scheme_suite_test.go index 942fcd478a..a11e08fa5c 100644 --- a/pkg/scheme/scheme_suite_test.go +++ b/pkg/scheme/scheme_suite_test.go @@ -21,9 +21,12 @@ import ( . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" + + "sigs.k8s.io/controller-runtime/pkg/envtest/printer" ) func TestScheme(t *testing.T) { RegisterFailHandler(Fail) - RunSpecs(t, "Scheme Suite") + suiteName := "Scheme Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } diff --git a/pkg/source/internal/internal_suite_test.go b/pkg/source/internal/internal_suite_test.go index 6c2a71894e..22d7a56841 100644 --- a/pkg/source/internal/internal_suite_test.go +++ b/pkg/source/internal/internal_suite_test.go @@ -28,7 +28,8 @@ import ( func TestInternal(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Internal Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Source Internal Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func() { diff --git a/pkg/source/source_suite_test.go b/pkg/source/source_suite_test.go index f2e488bbe4..c93bcca232 100644 --- a/pkg/source/source_suite_test.go +++ b/pkg/source/source_suite_test.go @@ -32,7 +32,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Source Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Source Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment diff --git a/pkg/webhook/admission/admission_suite_test.go b/pkg/webhook/admission/admission_suite_test.go index 8d5babb6f2..c767305077 100644 --- a/pkg/webhook/admission/admission_suite_test.go +++ b/pkg/webhook/admission/admission_suite_test.go @@ -29,7 +29,8 @@ import ( func TestAdmissionWebhook(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "application Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Admission Webhook Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func(done Done) { diff --git a/pkg/webhook/conversion/conversion_suite_test.go b/pkg/webhook/conversion/conversion_suite_test.go index c90dce4182..a724f15302 100644 --- a/pkg/webhook/conversion/conversion_suite_test.go +++ b/pkg/webhook/conversion/conversion_suite_test.go @@ -28,7 +28,8 @@ import ( func TestConversionWebhook(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "CRD conversion Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "CRD conversion Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var _ = BeforeSuite(func(done Done) { diff --git a/pkg/webhook/webhook_suite_test.go b/pkg/webhook/webhook_suite_test.go index 87ccf70e66..a89ec7b24e 100644 --- a/pkg/webhook/webhook_suite_test.go +++ b/pkg/webhook/webhook_suite_test.go @@ -32,7 +32,8 @@ import ( func TestSource(t *testing.T) { RegisterFailHandler(Fail) - RunSpecsWithDefaultAndCustomReporters(t, "Webhook Integration Suite", []Reporter{printer.NewlineReporter{}}) + suiteName := "Webhook Integration Suite" + RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) } var testenv *envtest.Environment