-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.19] 🐛 Refactor certificate watcher to use polling, instead of fsnotify #3023
[release-0.19] 🐛 Refactor certificate watcher to use polling, instead of fsnotify #3023
Conversation
/approve |
LGTM label has been added. Git tree hash: d413ca52394d17463a54ec3c911a442cef4abf46
|
@m-messiah seems like there is a null pointer exception in the tests on this release branch |
The test introduces the new check that uses golang 1.23 feature, while this release is tested in go 1.22. I pushed a bugfix with backwards compatible test: #3026 |
/approve |
LGTM label has been added. Git tree hash: 5f501e3b5122827d350d208740bf24f826d9308f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, m-messiah, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e727239
into
kubernetes-sigs:release-0.19
/cherry-pick release-0.18 |
@vincepri: #3023 failed to apply on top of branch "release-0.18":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… of fsnotify (#3023) * Reestablish watch for the certificate paths * Remove fsnotify and use cached read watcher * Simplify return * 🐛Fix certwatcher test to be backwards compatible --------- Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com>
… of fsnotify (#3023) * Reestablish watch for the certificate paths * Remove fsnotify and use cached read watcher * Simplify return * 🐛Fix certwatcher test to be backwards compatible --------- Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com> Signed-off-by: Vince Prignano <vince@prigna.com>
… of fsnotify (#3023) * Reestablish watch for the certificate paths * Remove fsnotify and use cached read watcher * Simplify return * 🐛Fix certwatcher test to be backwards compatible --------- Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com> Signed-off-by: Vince Prignano <vince@prigna.com>
… of fsnotify (#3023) * Reestablish watch for the certificate paths * Remove fsnotify and use cached read watcher * Simplify return * 🐛Fix certwatcher test to be backwards compatible --------- Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com> Signed-off-by: Vince Prignano <vince@prigna.com>
This is an automated cherry-pick of #3020
/assign vincepri