Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] 🐛 Refactor certificate watcher to use polling, instead of fsnotify #3023

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #3020

/assign vincepri

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@vincepri vincepri added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 26, 2024
@m-messiah
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d413ca52394d17463a54ec3c911a442cef4abf46

@vincepri
Copy link
Member

@m-messiah seems like there is a null pointer exception in the tests on this release branch

@m-messiah
Copy link
Member

@m-messiah seems like there is a null pointer exception in the tests on this release branch

The test introduces the new check that uses golang 1.23 feature, while this release is tested in go 1.22.

I pushed a bugfix with backwards compatible test: #3026

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@vincepri
Copy link
Member

vincepri commented Dec 2, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f501e3b5122827d350d208740bf24f826d9308f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, m-messiah, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2024

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff-release-0-19 56d6cb0 link false /test pull-controller-runtime-apidiff-release-0-19

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit e727239 into kubernetes-sigs:release-0.19 Dec 2, 2024
7 of 8 checks passed
@vincepri
Copy link
Member

vincepri commented Dec 2, 2024

/cherry-pick release-0.18

@k8s-infra-cherrypick-robot
Copy link
Author

@vincepri: #3023 failed to apply on top of branch "release-0.18":

Applying: Reestablish watch for the certificate paths
Applying: Remove fsnotify and use cached read watcher
Using index info to reconstruct a base tree...
M	examples/scratch-env/go.mod
M	examples/scratch-env/go.sum
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging examples/scratch-env/go.sum
CONFLICT (content): Merge conflict in examples/scratch-env/go.sum
Auto-merging examples/scratch-env/go.mod
CONFLICT (content): Merge conflict in examples/scratch-env/go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Remove fsnotify and use cached read watcher

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vincepri pushed a commit that referenced this pull request Dec 2, 2024
… of fsnotify (#3023)

* Reestablish watch for the certificate paths

* Remove fsnotify and use cached read watcher

* Simplify return

* 🐛Fix certwatcher test to be backwards compatible

---------

Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com>
vincepri added a commit that referenced this pull request Dec 2, 2024
… of fsnotify (#3023)

* Reestablish watch for the certificate paths

* Remove fsnotify and use cached read watcher

* Simplify return

* 🐛Fix certwatcher test to be backwards compatible

---------

Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com>
Signed-off-by: Vince Prignano <vince@prigna.com>
vincepri added a commit that referenced this pull request Dec 2, 2024
… of fsnotify (#3023)

* Reestablish watch for the certificate paths

* Remove fsnotify and use cached read watcher

* Simplify return

* 🐛Fix certwatcher test to be backwards compatible

---------

Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com>
Signed-off-by: Vince Prignano <vince@prigna.com>
vincepri added a commit that referenced this pull request Dec 2, 2024
… of fsnotify (#3023)

* Reestablish watch for the certificate paths

* Remove fsnotify and use cached read watcher

* Simplify return

* 🐛Fix certwatcher test to be backwards compatible

---------

Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com>
Signed-off-by: Vince Prignano <vince@prigna.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants