🐛Fix certwatcher test to be backwards compatible #3026
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3020 improved the certwatcher test to check not only the privatekeys, but the certificate data too.
The test was using
cert.Leaf
field that is populated since Go 1.23 only (which is used in the main branch), so fails in the release-0.19 #3023.The PR updates the test to use certificate comparison that should work in all previous versions of Go properly.
Note, it checks
Certificate[0]
which might be wrong in broken chains, but this is the default behavior oftls.X509KeyPair
- it always parses the first certificate only. And also note, that there is no need in len checks as the certificate is guaranteed to be present, otherwise Parse would return error earlier.