From 715d27e5c37234b0585acd4209ef4b31e376e355 Mon Sep 17 00:00:00 2001
From: josvaz <jose.vazquez@mongodb.com>
Date: Wed, 11 Sep 2024 12:10:02 +0200
Subject: [PATCH] :bug: Allow CLI binaries to set a version (#1049)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Allow CLI binaries to set a version

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Release binaries with RELEASE_TAG as version

* Make workflow pass the RELEASE_TAG env var

* Update version help comment

Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>

---------

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>
---
 .github/workflows/release.yaml    |  2 ++
 Makefile                          |  3 +-
 pkg/version/version.go            |  8 +++++
 pkg/version/version_suite_test.go | 29 +++++++++++++++++
 pkg/version/version_test.go       | 53 +++++++++++++++++++++++++++++++
 5 files changed, 94 insertions(+), 1 deletion(-)
 create mode 100644 pkg/version/version_suite_test.go
 create mode 100644 pkg/version/version_test.go

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 9adc4ebf6..607dcebce 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -14,6 +14,8 @@ jobs:
     name: Upload binaries to release
     runs-on: ubuntu-latest
     steps:
+    - name: Set env
+      run:  echo "RELEASE_TAG=${GITHUB_REF:10}" >> $GITHUB_ENV
     - name: Check out code
       uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # tag=v4.1.7
     - name: Calculate go version
diff --git a/Makefile b/Makefile
index 961ad9c41..c00d60909 100644
--- a/Makefile
+++ b/Makefile
@@ -178,7 +178,8 @@ release-binary: $(RELEASE_DIR)
 		-v "$$(pwd):/workspace$(DOCKER_VOL_OPTS)" \
 		-w /workspace \
 		golang:$(GO_VERSION) \
-		go build -a -trimpath -ldflags "-extldflags '-static'" \
+		go build -a -trimpath \
+		-ldflags "-extldflags '-static' -X sigs.k8s.io/controller-tools/pkg/version.version=$(RELEASE_TAG)" \
 		-o ./out/$(RELEASE_BINARY) ./cmd/controller-gen
 
 ## --------------------------------------
diff --git a/pkg/version/version.go b/pkg/version/version.go
index f2709df4a..8d55cb597 100644
--- a/pkg/version/version.go
+++ b/pkg/version/version.go
@@ -22,8 +22,16 @@ import (
 	"runtime/debug"
 )
 
+// version to be set using ldflags:
+// -ldflags "-X sigs.k8s.io/controller-tools/pkg/version.version=v1.0.0"
+// falls back to module information is unset
+var version = ""
+
 // Version returns the version of the main module
 func Version() string {
+	if version != "" {
+		return version
+	}
 	info, ok := debug.ReadBuildInfo()
 	if !ok || info == nil || info.Main.Version == "" {
 		// binary has not been built with module support or doesn't contain a version.
diff --git a/pkg/version/version_suite_test.go b/pkg/version/version_suite_test.go
new file mode 100644
index 000000000..dea3230b4
--- /dev/null
+++ b/pkg/version/version_suite_test.go
@@ -0,0 +1,29 @@
+/*
+Copyright 2024 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package version
+
+import (
+	"testing"
+
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+)
+
+func TestVersioning(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Test Version Suite")
+}
diff --git a/pkg/version/version_test.go b/pkg/version/version_test.go
new file mode 100644
index 000000000..3ec9b414d
--- /dev/null
+++ b/pkg/version/version_test.go
@@ -0,0 +1,53 @@
+/*
+Copyright 2024 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package version
+
+import (
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+)
+
+var _ = Describe("TestVersion", func() {
+	tests := []struct {
+		name     string
+		version  string
+		expected string
+	}{
+		{
+			name:     "empty returns unknown",
+			version:  "",
+			expected: "(unknown)",
+		},
+		{
+			name:     "set to a value returns it",
+			version:  "1.2.3",
+			expected: "1.2.3",
+		},
+	}
+	for _, tc := range tests {
+		It("Version set to "+tc.name, func() {
+			versionBackup := version
+			defer func() {
+				version = versionBackup
+			}()
+			version = tc.version
+			result := Version()
+			Expect(result).To(Equal(tc.expected))
+		})
+	}
+})
+