-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller-gen cannot be properly versioned without patching the existing code #1046
Comments
cc @vincepri |
and cc @sbueringer 🙏 |
@josvazg @s-urbaniak Thx for opening the issue. I missed checking for the version when implementing the binary releases. Proposal sounds good to me, feel free to open a PR |
Thanks @sbueringer ! Just posted #1049 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Fix merged, we can close this now |
The version computing code assumes the usage of the
controller-gen
will always be as a module:Moreover, downloading the official released binaries from this repo directly they still render
(devel)
as the binary version.This is not CI or reproducible environment friendly. Ideally, you would define your dependency version on some file, then just have it available in your environment.
Using the module approach and updating your
go.mod
does not make the binary available aftergo mod tidy
, so the CI will not be able to usecontroller-gen
.There is no ready available packaging such as with brew or Debian.
Reproducible builds with versioning exist from nix, by patching the versioning code in this repository.
Given than using the CLI generator tool as a module is not natively supported by Go, and that a binary distribution of some kind is required, we would like to propose the following change.
ldflags
, for instance-X sigs.k8s.io/controller-tools/pkg/version.Version=X.Y.Z
info.Main.Version
with such localVersion
value.We are ready to follow up with a patch for this.
The text was updated successfully, but these errors were encountered: