-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should metav1.Time CRD generation specify nullable if the field is optional? #812
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
Not sure if we want to start inferring additional markers based on types. |
That's fair - thanks for the info. Feel free to close this if you feel like the behaviour is intentional. |
Really not sure :), let's see if others have opinions. (cc @vincepri @alvaroaleman) |
json:"releaseTime,omitempty
k8s.io/code-generator v0.27.1
generate a client.spec.releaseTime: Invalid value: "null": spec.releaseTime in body must be of type string: "null"
//+nullable
marker to the field to get the schema to becomeSeems like this should happen by default if the field is optional.
The text was updated successfully, but these errors were encountered: