Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resClient.List should add resourceVersion=0 parameter #154

Open
xiaomudk opened this issue Jul 6, 2023 · 2 comments
Open

resClient.List should add resourceVersion=0 parameter #154

xiaomudk opened this issue Jul 6, 2023 · 2 comments
Assignees
@logicalhan
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@xiaomudk
Copy link

xiaomudk commented Jul 6, 2023

resourceVersion=0 is not specified here, causing apiserver to skip the cache and go directly to etcd to read the data.
add resourceVersion=0 parameter, apiserver will read data from the cache, and there is an order of magnitude performance improvement.
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 6, 2023
@xiaomudk xiaomudk mentioned this issue Jul 6, 2023
Closed
@logicalhan
Copy link

/triage accepted
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 13, 2023
@dgrisonnet
Copy link
Member

I don't think that's something we want to do since it might be hitting stale data from the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logicalhan logicalhan

Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resClient.List add resourceVersion=0 parameter xiaomudk/custom-metrics-apiserver
4 participants
@logicalhan @xiaomudk @k8s-ci-robot @dgrisonnet