Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple adapters in cluster? #59

Closed
zroubalik opened this issue Nov 20, 2019 · 4 comments
Closed

Multiple adapters in cluster? #59

zroubalik opened this issue Nov 20, 2019 · 4 comments

Comments

@zroubalik
Copy link
Contributor

zroubalik commented Nov 20, 2019

Is there a way how to deploy multiple adapters in a cluster? Eg. there's already deployed custom metrics server Foo and I need to deploy my own implementation Bar which provides different set of metrics.

If I understand it correctly, to be able to provide custome/external metrics API, the adapter needs to deploy cluster wide APIService with a specific name. Deploying second adapter in the cluster will results in reconfiguring the original APIService object.

apiVersion: apiregistration.k8s.io/v1beta1
kind: APIService
metadata:
  name: v1beta1.custom.metrics.k8s.io
spec:
  service:
    name: custom-metrics-apiserver
    namespace: custom-metrics
  group: custom.metrics.k8s.io
  version: v1beta1
  insecureSkipTLSVerify: true
  groupPriorityMinimum: 100
  versionPriority: 100
@markusthoemmes
Copy link

This is a duplicate of #3 I think.

@ecordell
Copy link

I think #3 would have been a solution to the problem, but I like that this issue states the problem rather than the solution.

Have any other solutions been discussed before? Is there a reason, for example, that all custom metrics must share the same apigroup?

@s-urbaniak
Copy link
Contributor

@ecordell i don't know if the question is still relevant, but just to give another potential solution is to solve it in the underlying monitoring system. Probably it is not applicable to all adapters out there, but in the Prometheus ecosystem this can easily be achieved using a Thanos based setup, see [1] and [2].

[1] kubernetes-sigs/prometheus-adapter#267
[2] https://www.youtube.com/watch?v=qTxunwzYO0g

@zroubalik
Copy link
Contributor Author

@s-urbaniak I'd like to kindly ask why is this issue closed? Prometheus adapter is not the only usecase, from my POV this problem is still relevant. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants