Use pod-template-hash label in addition to topology spread constraint matchLabels

[jklaw90]

Is your feature request related to a problem? Please describe.

Multiple deployments can exist with the same topology spread constraint match labels. This means that our topology spread constraint strategy may group multiple deployments and consider them as one.

Describe the solution you'd like

We should use the pod-template-hash ensure unique deployments are calculated separately.

Describe alternatives you've considered

None

What version of descheduler are you using?

descheduler version:
1.24

Additional context

[a7i]

Adding our discussion here as well for reference.

Given that kubernetes/kubernetes#111441 has been merged, Descheduler could use the new MatchLabelKeys field similar to how Scheduler is using it today.

cc: @damemi for insights, given he created the Scheduler issue.

[jklaw90]

I saw the pr after i logged this issue. I agree i didn't realize only the deployment controller was using the pod hash. I can change the scope of the issue or close it out.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten