-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pod-template-hash label in addition to topology spread constraint matchLabels #917
Comments
Adding our discussion here as well for reference. Given that kubernetes/kubernetes#111441 has been merged, Descheduler could use the new cc: @damemi for insights, given he created the Scheduler issue. |
I saw the pr after i logged this issue. I agree i didn't realize only the deployment controller was using the pod hash. I can change the scope of the issue or close it out. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Is your feature request related to a problem? Please describe.
Multiple deployments can exist with the same topology spread constraint match labels. This means that our topology spread constraint strategy may group multiple deployments and consider them as one.
Describe the solution you'd like
We should use the pod-template-hash ensure unique deployments are calculated separately.
Describe alternatives you've considered
None
What version of descheduler are you using?
descheduler version:
1.24
Additional context
The text was updated successfully, but these errors were encountered: