-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube-lego managed Ingress resources #182
Comments
👍 the de-duplication approach sounds reasonable. |
This is fixed in The |
Moving this to |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I have been attempting to fully automate the provisioning and binding of ingress resources on AWS using nginx-ingress, kube-lego and external-dns. kube-lego behind the scenes is creating a shadow Ingress resource in the
kube-system
namespace to manage some of the TLS challenge process.The issue I am running into is that the external-dns'
Ingress
source assumes that if theexternal-dns.alpha.kubernetes.io/controller
annotation is missing, it should make a DNS request. Ultimately this has lead to a situation where the resource in multiple, identical changes being added to the batch.A few ways this could be approached would be:
As an additional scenario, I can see a situation (especially using path based ingress) where one may want to represent the same
Host
attribute in multiple Ingress resources with different paths which would lean me heavily towards the de-dup to unique records prior to the call toChangeResourceRecordSets
The text was updated successfully, but these errors were encountered: