-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upper-case CNAME target causing constantly creation and deletion on Cloudflare #1906
Comments
I've had a dig into this. Cloudflare will store CNAME records as lowercase - the plan logic (specifically Logic in the provider (in this case Cloudflare), which calls The I think there are a couple of bugs here:
Problem 1 looks quite straightforward to fix, but there are few ways we could fix problem 2:
I'm new to this project so unsure what the best approach would be. Perhaps one of the maintainers could point us in the right direction - I'm happy to raise a PR. |
@robselway |
Yeah just convert to lowercase makes sense. |
What happened:
When setting an upper-case CNAME target in ingress object through the annotation, ExternalDNS constantly creates and deletes the CNAME record every 1 minute (same as the specified update interval).
This can be confirmed from Cloudflare audit log as well as ExternalDNS log as below.
Note that the deletion happens even when
--policy=upsert-only
is set, meaning the policy is not respected.Good news is everything works fine if the CNAME target is converted to lower-case first
What you expected to happen:
--policy=upsert-only
and not delete the CNAME record in this case.How to reproduce it (as minimally and precisely as possible):
The cli arguments.
And the ingress.
Anything else we need to know?:
Environment:
external-dns --version
): v0.7.5The text was updated successfully, but these errors were encountered: