Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSSD: Cleanup empty Service #2509

Closed
voro015 opened this issue Jan 10, 2022 · 0 comments · Fixed by #2510
Closed

AWSSD: Cleanup empty Service #2509

voro015 opened this issue Jan 10, 2022 · 0 comments · Fixed by #2510
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@voro015
Copy link
Contributor

voro015 commented Jan 10, 2022

What would you like to be added:
AWSSD provider aka AWS CloudMap should remove CloudMap Services when its last Instance de-registered.

Why is this needed:
In case when external-dns is used with fqdn-template to generate CloudMap Services it will create new CM Services each time, but in case when there are no Endpoints left for particular CM Service it will be left empty in CM Namespace.
If it's ran in highly scalable env at some point CM Namespace will contains tens of thousands of empty CM Services and external-dns will read all of them on each reconciliation loop.
Some form of cleanup is required to use it successfully.

@voro015 voro015 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant