-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release new chart version #2570
Comments
Any thoughts guys? |
@Raffo @njuettner are you happy for me to go ahead and start the chart release process? |
Sure, what do you need from us? |
@Raffo nothing, I didn't want to do it without checking first. I'm happy to manage the chart release cycle moving forwards and just ask for approval on the PRs if that works better? |
@stevehipwell yes absolutely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have the chart changes from two PRs to be released, #2477 & #2564. Should we be waiting to release these with an ExternalDNS release or do we want to release them now?
IMHO this process is better than allowing PRs to come through with changes to Chart.yaml as the last release had new features but was released as a patch without updated changelog annotations just before more chart changes were merged. I propose that from now onwards all chart PRs don't modify Chart.yaml but capture the changes in a CHANGELOG.md to be used to create a release PR.We already updated the contributing guide for the chart to say that all chart changes shouldn't update Chart.yaml, so we (or rather I in this case) need to enforce this. I'll update the guide to add recoding changes in CHANGELOG.md so the chart annotations can be added by the person doing the release.
Draft PR incoming.
CC @Raffo @njuettner
The text was updated successfully, but these errors were encountered: