Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-approved.kubernetes.io missing from CRD since 0.14.2 #4487

Closed
morremeyer opened this issue May 20, 2024 · 1 comment · Fixed by #4488
Closed

api-approved.kubernetes.io missing from CRD since 0.14.2 #4487

morremeyer opened this issue May 20, 2024 · 1 comment · Fixed by #4488
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@morremeyer
Copy link
Contributor

What happened: 4e6dd80 removed the api-approved.kubernetes.io annotation which is required.

What you expected to happen: The annotation to not be removed. It is required as explained in #2008 and initially added in #2007.

How to reproduce it (as minimally and precisely as possible): Try to kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/external-dns/v0.14.2/docs/contributing/crd-source/crd-manifest.yaml and observe the error:

Required value: protected groups must have approval annotation "api-approved.kubernetes.io", see https://github.com/kubernetes/enhancements/pull/1111

This can also be seen in https://github.com/community-tooling/charts/actions/runs/9149321522/job/25152820816?pr=277

Anything else we need to know?:

Environment:

  • External-DNS version (use external-dns --version): 0.14.2
  • DNS provider: irrelevant
@morremeyer
Copy link
Contributor Author

Duplicate of #4483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant