Expose ExternalIP of Node as annotation on headless service #1077

aaronhenshaw · 2019-06-24T16:39:44Z

Use Case:
We need to have external-dns set our DNS to point to the ExternalIP of the node that the pod winds up on.

Added an annotation "use-external-host-ip" for Services
This will only work when "publish-host-ip" is set on the external-dns deployment

I believe this is kind of mentioned in #632

k8s-ci-robot · 2019-06-24T16:39:45Z

Welcome @aaronhenshaw!

It looks like this is your first PR to kubernetes-incubator/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-06-24T16:39:47Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aaronhenshaw · 2019-06-24T16:49:48Z

I signed it

zzh8829 · 2019-07-02T20:48:36Z

This feature is very useful for people that don't use LoadBalancer from cloud providers.
Currently, the only other way to expose a service to ExternalIP is using NodePort.
However, NodePort is not a very ideal fit, since it doesn't work on ports < 3000.

I think supporting Headless ClusterIP + HostPort + ExternalIP is the way to go for this use case.
Hopefully we can get this PR released soon 🚀

source/service.go

vsimon · 2019-07-11T17:43:54Z

source/service.go

@@ -365,6 +380,11 @@ func (sc *serviceSource) generateEndpoints(svc *v1.Service, hostname string, pro
 		log.Warn(err)
 	}

+	externalIp := getExternalIpFromAnnotations(svc.Annotations)
+	if err != nil {


Should there be an err coming from getExternalIpFromAnnotations or should externalIp be checked instead? (as this is, this is checking the err coming from getTTLFromAnnotations)

I removed the check, not sure it's necessary.

The only thing I could do would be if its not "true" but it exists I could throw an error. What do you think?

aaronhenshaw · 2019-08-04T22:05:15Z

@vsimon, @zzh8829 updated per feedback, let me know if there is anything else. Sorry it took so long, been so swamped recently.

vsimon · 2019-08-04T23:21:07Z

Thanks @aaronhenshaw, can't wait to check this out! The little script snippet in #632 has been chugging along without issue for months now 😃

tommyknows · 2019-09-04T20:51:07Z

Hi, any progress on this?
I think this feature would also be useful for scenarios where the loadbalancer IPs are in a NATed network.
For example, I have MetalLB provisioning IPs in 192.168.1.1xx, and am using port-forwarding on the router / firewall. I would like to expose the router's Public IP as the DNS endpoint, and not the private IP of the loadbalancer.
Would this PR allow this scenario too?

aaronhenshaw · 2019-09-04T21:53:23Z

Yeah I would love to get this merged if possible. Or if there is any other feedback I am happy to incorporate it. cc @vsimon @zzh8829

vsimon · 2019-09-04T22:02:57Z

I don't have any other feedback. I don't have approval privileges. The ball is on one of the approvers I guess.

zzh8829 · 2019-09-14T21:19:19Z

I have been using my own docker image from this branch for a while, would be great if we can get this into the official image. @linki @Raffo do you guys have some time for code reviews?

domingusj · 2019-11-05T04:10:19Z

@zzh8829 any chance you could post the steps you used to create the modified container image? I'd also love to have this feature

jeanlucmongrain · 2019-11-07T08:08:22Z

I guess this project is falling in unmaintained status, if PR are ignored

aaronhenshaw · 2019-11-11T02:17:31Z

There is still regular activity here. It would be great to get an update or any info on getting this merged. I am happy to make changes, etc if that would help. @linki @Raffo

zzh8829 · 2019-11-14T08:20:51Z

@domingusj i cloned this branch and then compiled dockerfile.
you can use my prebuild here at zihao/play:external-dns its 2 month old tho

TheUltimateC0der · 2019-11-14T13:15:44Z

I also did an image myself. Its based on the latest master. you can check the repo and image out here https://github.com/TheUltimateC0der/external-dns
https://hub.docker.com/r/theultimatecoder/external-dns

domingusj · 2019-11-14T15:24:48Z

Thank you @zzh8829 and @TheUltimateC0der. I'll do some testing this week. And hopefully your PR will get approved and released soon @aaronhenshaw! Thanks for the contribution!

aaronhenshaw · 2020-01-29T14:33:13Z

Hey any updates here. We would love to get this merged and move back to using the external-dns main releases!

Thanks!

k8s-triage-robot · 2022-05-01T20:56:12Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mindw · 2022-05-04T09:59:49Z

/remove-lifecycle stale

seh · 2022-05-06T12:59:26Z

#2115 merged, which might suffice as an alternative.

k8s-ci-robot · 2022-05-06T12:59:32Z

@aaronhenshaw: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2022-08-04T13:11:25Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mindw · 2022-08-06T06:50:20Z

/remove-lifecycle stale

k8s-triage-robot · 2022-11-04T07:29:28Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ThisIsQasim · 2022-11-04T09:19:26Z

/remove-lifecycle stale

k8s-triage-robot · 2023-02-02T09:39:55Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mindw · 2023-02-02T15:49:55Z

/remove-lifecycle stale

k8s-triage-robot · 2023-05-03T16:10:51Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ThisIsQasim · 2023-05-03T16:18:09Z

/remove-lifecycle stale

mloiseleur · 2023-12-20T15:39:41Z

@aaronhenshaw Do you think you can rebase this PR ?

mloiseleur · 2024-01-15T07:19:26Z

Since author is not answering, I'm closing this PR.
Feel free to re-open it or open a new one if you need it.
/close

k8s-ci-robot · 2024-01-15T07:19:31Z

@mloiseleur: Closed this PR.

In response to this:

Since author is not answering, I'm closing this PR.
Feel free to re-open it or open a new one if you need it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvaidya · 2024-10-27T21:25:10Z

This is still needed for self-hosted kubernetes clusters - MetalLB exposes the internal NAT IP as the loadbalancer IP, which is then getting published as an A record by external-dns.

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 24, 2019

k8s-ci-robot requested review from linki and Raffo June 24, 2019 16:39

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 24, 2019

zzh8829 reviewed Jul 11, 2019

View reviewed changes

source/service.go Outdated Show resolved Hide resolved

vsimon reviewed Jul 11, 2019

View reviewed changes

aaronhenshaw force-pushed the external-host-ip branch 2 times, most recently from 77f4264 to 7758ceb Compare August 4, 2019 22:02

martinohansen mentioned this pull request Jan 25, 2020

[Feature Request] Support ClusterIP services with externalIPs set #1281

Open

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2020

domingusj mentioned this pull request Feb 17, 2020

Publish externalIPs of Nodes running Pods in headless service #1391

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2022

seh mentioned this pull request Jun 10, 2022

Headless should use ExternalIP when using --publish-host-ip #1263

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 4, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2023

k8s-ci-robot closed this Jan 15, 2024

rvaidya mentioned this pull request Oct 27, 2024

Add support for "target" annotation on ingress service #4627

Closed

Expose ExternalIP of Node as annotation on headless service #1077

Expose ExternalIP of Node as annotation on headless service #1077

Conversation

aaronhenshaw commented Jun 24, 2019

k8s-ci-robot commented Jun 24, 2019

k8s-ci-robot commented Jun 24, 2019

aaronhenshaw commented Jun 24, 2019

zzh8829 commented Jul 2, 2019

vsimon Jul 11, 2019

Choose a reason for hiding this comment

aaronhenshaw Aug 4, 2019

Choose a reason for hiding this comment

aaronhenshaw commented Aug 4, 2019

vsimon commented Aug 4, 2019 • edited Loading

tommyknows commented Sep 4, 2019 • edited Loading

aaronhenshaw commented Sep 4, 2019

vsimon commented Sep 4, 2019

zzh8829 commented Sep 14, 2019 • edited Loading

domingusj commented Nov 5, 2019

jeanlucmongrain commented Nov 7, 2019

aaronhenshaw commented Nov 11, 2019

zzh8829 commented Nov 14, 2019

TheUltimateC0der commented Nov 14, 2019

domingusj commented Nov 14, 2019

aaronhenshaw commented Jan 29, 2020

k8s-triage-robot commented May 1, 2022

mindw commented May 4, 2022

seh commented May 6, 2022

k8s-ci-robot commented May 6, 2022

k8s-triage-robot commented Aug 4, 2022

mindw commented Aug 6, 2022

k8s-triage-robot commented Nov 4, 2022

ThisIsQasim commented Nov 4, 2022

k8s-triage-robot commented Feb 2, 2023

mindw commented Feb 2, 2023

k8s-triage-robot commented May 3, 2023

ThisIsQasim commented May 3, 2023

mloiseleur commented Dec 20, 2023

mloiseleur commented Jan 15, 2024

k8s-ci-robot commented Jan 15, 2024

rvaidya commented Oct 27, 2024

vsimon commented Aug 4, 2019 •

edited

Loading

tommyknows commented Sep 4, 2019 •

edited

Loading

zzh8829 commented Sep 14, 2019 •

edited

Loading