Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New provider specific update #3177

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix: New provider specific update #3177

merged 1 commit into from
Nov 22, 2022

Conversation

gjmveloso
Copy link
Contributor

The previous code version only iterates over current ProviderSpecific properties. This new version iterates over desired properties, including those that were just set.

Description

shouldUpdateProviderSpecific seems to be iterating over just the current properties that were previously set, not taking into consideration for planning changes when additional ProviderSpecific properties were just set.

Fixes #2953

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 21, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 21, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gjmveloso / name: Gustavo Veloso (4adf284)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @gjmveloso!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 21, 2022
@gjmveloso
New provider-specific properties support when updating DNS records
ca07f0a 
shouldUpdateProviderSpecific seems to be iterating over just the current properties that were previously set, not taking into consideration for planning changes when additional ProviderSpecific properties were just set.

The previous code version only iterates over current ProviderSpecific properties. This new version iterates over desired properties, including those that were just set.
@gjmveloso gjmveloso force-pushed the fix/new-provider-specific-update branch from 4adf284 to ca07f0a Compare November 21, 2022 22:42
@gjmveloso
Copy link
Contributor Author

/retitle

@k8s-ci-robot
Copy link
Contributor

@gjmveloso: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gjmveloso gjmveloso changed the title Initial work to fix #2953 fix: New provider specific update Nov 21, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 21, 2022
@szuecs
Copy link
Contributor

szuecs commented Nov 22, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjmveloso, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit ee77277 into kubernetes-sigs:master Nov 22, 2022
@gjmveloso gjmveloso mentioned this pull request Nov 22, 2022
Closed
2 tasks
@gjmveloso
Copy link
Contributor Author

@szuecs, there is an issue with the previous code submitted. I had created the PR #3180 to fix it.

@Raffo Raffo mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@szuecs szuecs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No DNS update when new provider-specific properties are added to an existing ingress
3 participants
@gjmveloso @k8s-ci-robot @szuecs