From f07480888d5794938c2fd9b57127527675e13565 Mon Sep 17 00:00:00 2001 From: Michel Loiseleur Date: Fri, 9 Feb 2024 09:00:50 +0100 Subject: [PATCH] fix: flaky test on coredns provider --- provider/coredns/coredns_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/provider/coredns/coredns_test.go b/provider/coredns/coredns_test.go index 84f124ac50..bbed29f729 100644 --- a/provider/coredns/coredns_test.go +++ b/provider/coredns/coredns_test.go @@ -32,11 +32,12 @@ type fakeETCDClient struct { } func (c fakeETCDClient) GetServices(prefix string) ([]*Service, error) { - var result []*Service + result := make([]*Service, 0, len(c.services)) for key, value := range c.services { if strings.HasPrefix(key, prefix) { - value.Key = key - result = append(result, value) + valueCopy := *value + valueCopy.Key = key + result = append(result, &valueCopy) } } return result, nil