-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from glide to dep #435
Switch from glide to dep #435
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
09f989a
to
93f041b
Compare
93f041b
to
7f36969
Compare
is the issue with repo-infra resolved ? (I saw it being mentioned in the original post) |
This issue still exists with the kazel package but I was able to use the ignore section in go dep to ignore that particular component. The overall result is a much smaller diff with the same result. |
lgtm |
1 similar comment
lgtm |
…_glide_to_dep Switch from glide to dep
* Some refactoring improvements * don't shadow imports or builtins such as `os` and `close` respectively. * use wrapper ReplaceAll * combine types in func calls if same type * More refactoring and golangci config improvement * Run go mod tidy * Use cmp in tests * Rename GoOSArch to OSArchPair
Solves #431