Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from glide to dep #435

Merged

Conversation

bkochendorfer
Copy link
Contributor

@bkochendorfer bkochendorfer commented Jan 5, 2018

Solves #431

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 5, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 5, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2018
@ideahitme
Copy link

ideahitme commented Jan 9, 2018

is the issue with repo-infra resolved ? (I saw it being mentioned in the original post)

@bkochendorfer
Copy link
Contributor Author

This issue still exists with the kazel package but I was able to use the ignore section in go dep to ignore that particular component. The overall result is a much smaller diff with the same result.

@linki
Copy link
Member

linki commented Jan 11, 2018

lgtm

1 similar comment
@njuettner
Copy link
Member

lgtm

@njuettner njuettner merged commit 35b033a into kubernetes-sigs:master Jan 18, 2018
grimmy pushed a commit to grimmy/external-dns that referenced this pull request Apr 10, 2018
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
* Some refactoring improvements

* don't shadow imports or builtins such as
`os` and `close` respectively.
* use wrapper ReplaceAll
* combine types in func calls if same type

* More refactoring and golangci config improvement

* Run go mod tidy

* Use cmp in tests

* Rename GoOSArch to OSArchPair
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants