-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(txt-suffix): avoid crash on domain without dot #4885
base: master
Are you sure you want to change the base?
Conversation
Hi @titilambert. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle fix(txt-suffix): avoid crash on domain without dot |
/ok-to-test |
Good idea ! I will add a commit later today. |
Done ! |
@titilambert You have to fix this commit, too. |
afb2fd6
to
f1470b1
Compare
Sorry, I missed it. I just squashed, changed commit message and force pushed. |
Done |
I don't think they are super informative and won't really help in a running system. I understand the use for development, but I think we should remove them. Can you take care of this @titilambert ? |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
done ! |
Description
This PR fix issue when suffix is used and the domain has no dot
Fixes #1668
Checklist