Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(txt-suffix): avoid crash on domain without dot #4885

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

titilambert
Copy link
Contributor

Description

This PR fix issue when suffix is used and the domain has no dot

Fixes #1668

Checklist

  • Unit tests updated
  • [N/A] End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 19, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @titilambert. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2024
registry/txt.go Outdated Show resolved Hide resolved
@mloiseleur
Copy link
Contributor

/retitle fix(txt-suffix): avoid crash on domain without dot

@k8s-ci-robot k8s-ci-robot changed the title Fix #1668 fix(txt-suffix): avoid crash on domain without dot Nov 19, 2024
@mloiseleur
Copy link
Contributor

/ok-to-test
@titilambert Wdyt of adding a log, too ?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2024
@titilambert
Copy link
Contributor Author

/ok-to-test @titilambert Wdyt of adding a log, too ?

Good idea ! I will add a commit later today.

@titilambert
Copy link
Contributor Author

/ok-to-test @titilambert Wdyt of adding a log, too ?

Done !

@mloiseleur
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

* [85a4b15](https://github.com/kubernetes-sigs/external-dns/commits/85a4b154f160819dcc8f469414d5e90fde1d64f8) Fix [wrong host entry crashes the whole external-dns pod #1668](https://github.com/kubernetes-sigs/external-dns/issues/1668)

@titilambert You have to fix this commit, too.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 20, 2024
@titilambert
Copy link
Contributor Author

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:

* [85a4b15](https://github.com/kubernetes-sigs/external-dns/commits/85a4b154f160819dcc8f469414d5e90fde1d64f8) Fix [wrong host entry crashes the whole external-dns pod #1668](https://github.com/kubernetes-sigs/external-dns/issues/1668)

@titilambert You have to fix this commit, too.

Sorry, I missed it. I just squashed, changed commit message and force pushed.

@titilambert
Copy link
Contributor Author

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:

* [85a4b15](https://github.com/kubernetes-sigs/external-dns/commits/85a4b154f160819dcc8f469414d5e90fde1d64f8) Fix [wrong host entry crashes the whole external-dns pod #1668](https://github.com/kubernetes-sigs/external-dns/issues/1668)

@titilambert You have to fix this commit, too.

Sorry, I missed it. I just squashed, changed commit message and force pushed.

Done

@mloiseleur
Copy link
Contributor

/lgtm
/assign @Raffo

@Raffo: I'll let you decide if we should keep or not those debug logs.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@Raffo
Copy link
Contributor

Raffo commented Nov 22, 2024

I don't think they are super informative and won't really help in a running system. I understand the use for development, but I think we should remove them. Can you take care of this @titilambert ?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mloiseleur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@titilambert
Copy link
Contributor Author

I don't think they are super informative and won't really help in a running system. I understand the use for development, but I think we should remove them. Can you take care of this @titilambert ?

done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong host entry crashes the whole external-dns pod
4 participants