Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds serviceAccountName field to pod spec #516

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Adds serviceAccountName field to pod spec #516

merged 1 commit into from
Apr 4, 2018

Conversation

seshness
Copy link
Contributor

@seshness seshness commented Apr 4, 2018

The nginx-ingress guide lists RBAC roles & bindings, but doesn't tie the Deployment to the specific ServiceAccount.

Links the Deployment to the ServiceAccount.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2018
@hjacobs hjacobs added the docs label Apr 4, 2018
@hjacobs
Copy link
Contributor

hjacobs commented Apr 4, 2018

Thanks for the PR!

@hjacobs hjacobs merged commit a7c6a77 into kubernetes-sigs:master Apr 4, 2018
grimmy pushed a commit to grimmy/external-dns that referenced this pull request Apr 10, 2018
@seshness @hjacobs
Update nginx-ingress.md (kubernetes-sigs#516)
136f62a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seshness @hjacobs @k8s-ci-robot