You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since people or system may apply namespace yaml file with no included-namespace labels on the namespaces, the attempts after the first time will be rejected if our webhook doesn't allow updating included namespaces without included-namespace label. Thus in #36, the webhook allows updating included namespace without the included-namespace label.
The HC reconciler would add the included-namespace label immediately, but there's a small gap in between. So we can consider using a mutating wehbook for that.
The text was updated successfully, but these errors were encountered:
Besides the small gap when the included-namespace label is missing mentioned above, mutating webhooks seem to work better for included namespaces (see #36 (comment))
We will add a mutating webhook to:
Remove included-namespace label on excluded namespaces
Ensure included-namespace label with correct value true on non-excluded namespaces
And replace the VWH rules in the namespace validator on illegal included-namespace labels.
Part of #9
See #36 (comment)
Since people or system may apply namespace yaml file with no
included-namespace
labels on the namespaces, the attempts after the first time will be rejected if our webhook doesn't allow updating included namespaces withoutincluded-namespace
label. Thus in #36, the webhook allows updating included namespace without theincluded-namespace
label.The HC reconciler would add the
included-namespace
label immediately, but there's a small gap in between. So we can consider using a mutating wehbook for that.The text was updated successfully, but these errors were encountered: