Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm extra controller args #385

Open
zfrhv opened this issue Aug 12, 2024 · 3 comments
Open

helm extra controller args #385

zfrhv opened this issue Aug 12, 2024 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@zfrhv
Copy link
Contributor

zfrhv commented Aug 12, 2024

hi @mochizuki875
I want to add --unpropagated-label= to the helm chart as mentioned in the docs:
https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/docs/user-guide/how-to.md#admin-managed-labels

should I add something like:

manager:
  extraArgs:
  - --unpropagated-label: app.kubernetes.io/instance

or something like:

manager:
  unpropagatedLabel: app.kubernetes.io/instance

?

because there are many other controller arguments

@kalexmills
Copy link

kalexmills commented Aug 23, 2024

This seems straightforward. I'll open a PR.

EDIT: ... or two. 😅

@mochizuki875
Copy link
Member

@zfrhv
Sorry for late a response...
IMO, it's preferable like that.

manager:
  unpropagatedLabel:
  - app.kubernetes.io/instance
  - example.com/foo

Additionally, it might be beneficial to handle --unpropagated-annotation similarly, as it appears to have similar characteristics to --unpropagated-label.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants