From ec42ee93bf69dafd5b7b7e136fb187c735ebeae1 Mon Sep 17 00:00:00 2001
From: Sean Liao <seankhliao@gmail.com>
Date: Fri, 27 Aug 2021 18:47:07 +0200
Subject: [PATCH] add flag to disable stackdriver

Tested: Replaced existing installation of hnc v0.8.0 and continued to
see errors. Added --enable-stackdriver=false and didn't observe any
errors.
---
 cmd/manager/main.go | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/cmd/manager/main.go b/cmd/manager/main.go
index 40b006820..2d9115769 100644
--- a/cmd/manager/main.go
+++ b/cmd/manager/main.go
@@ -54,6 +54,7 @@ var (
 
 var (
 	metricsAddr             string
+	enableStackdriver       bool
 	maxReconciles           int
 	enableLeaderElection    bool
 	leaderElectionId        string
@@ -82,6 +83,7 @@ func init() {
 func main() {
 	setupLog.Info("Parsing flags")
 	flag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
+	flag.BoolVar(&enableStackdriver, "enable-stackdriver", true, "If true, export metrics to stackdriver")
 	flag.BoolVar(&enableLeaderElection, "enable-leader-election", false,
 		"Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.")
 	flag.StringVar(&leaderElectionId, "leader-election-id", "controller-leader-election-helper",
@@ -110,22 +112,24 @@ func main() {
 	// Exporters use Application Default Credentials to authenticate.
 	// See https://developers.google.com/identity/protocols/application-default-credentials
 	// for more details.
-	setupLog.Info("Creating OpenCensus->Stackdriver exporter")
-	sd, err := stackdriver.NewExporter(stackdriver.Options{
-		// Stackdriver’s minimum stats reporting period must be >= 60 seconds.
-		// https://opencensus.io/exporters/supported-exporters/go/stackdriver/
-		ReportingInterval: stats.ReportingInterval,
-	})
-	if err == nil {
-		// Flush must be called before main() exits to ensure metrics are recorded.
-		defer sd.Flush()
-		err = sd.StartMetricsExporter()
+	if enableStackdriver {
+		setupLog.Info("Creating OpenCensus->Stackdriver exporter")
+		sd, err := stackdriver.NewExporter(stackdriver.Options{
+			// Stackdriver’s minimum stats reporting period must be >= 60 seconds.
+			// https://opencensus.io/exporters/supported-exporters/go/stackdriver/
+			ReportingInterval: stats.ReportingInterval,
+		})
 		if err == nil {
-			defer sd.StopMetricsExporter()
+			// Flush must be called before main() exits to ensure metrics are recorded.
+			defer sd.Flush()
+			err = sd.StartMetricsExporter()
+			if err == nil {
+				defer sd.StopMetricsExporter()
+			}
+		}
+		if err != nil {
+			setupLog.Error(err, "Could not create Stackdriver exporter")
 		}
-	}
-	if err != nil {
-		setupLog.Error(err, "Could not create Stackdriver exporter")
 	}
 
 	// Hook up OpenCensus to Prometheus.
@@ -134,7 +138,7 @@ func main() {
 	// the returned value since it doesn't do anything anyway. See:
 	// (https://github.com/census-ecosystem/opencensus-go-exporter-prometheus/blob/2b9ada237b532c09fcb0a1242469827bdb89df41/prometheus.go#L103)
 	setupLog.Info("Creating Prometheus exporter")
-	_, err = prometheus.NewExporter(prometheus.Options{
+	_, err := prometheus.NewExporter(prometheus.Options{
 		Registerer: metrics.Registry, // use the controller-runtime registry to merge with all other metrics
 	})
 	if err != nil {