From 875f79554fd9e30a2acde2f6b8954872fd7e9dc0 Mon Sep 17 00:00:00 2001 From: Daniel Vega-Myhre Date: Wed, 18 Oct 2023 22:52:51 +0000 Subject: [PATCH 1/2] fix typo in api comments --- api/jobset/v1alpha2/jobset_types.go | 2 +- config/components/crd/bases/jobset.x-k8s.io_jobsets.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/jobset/v1alpha2/jobset_types.go b/api/jobset/v1alpha2/jobset_types.go index c1f989dee..dbc20a7e8 100644 --- a/api/jobset/v1alpha2/jobset_types.go +++ b/api/jobset/v1alpha2/jobset_types.go @@ -69,7 +69,7 @@ type JobSetSpec struct { // FailurePolicy, if set, configures when to declare the JobSet as // failed. - // The JobSet is always declared failed if all jobs in the set + // The JobSet is always declared failed if any job in the set // finished with status failed. // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable" FailurePolicy *FailurePolicy `json:"failurePolicy,omitempty"` diff --git a/config/components/crd/bases/jobset.x-k8s.io_jobsets.yaml b/config/components/crd/bases/jobset.x-k8s.io_jobsets.yaml index 102009a25..226a42bf9 100644 --- a/config/components/crd/bases/jobset.x-k8s.io_jobsets.yaml +++ b/config/components/crd/bases/jobset.x-k8s.io_jobsets.yaml @@ -48,7 +48,7 @@ spec: properties: failurePolicy: description: FailurePolicy, if set, configures when to declare the - JobSet as failed. The JobSet is always declared failed if all jobs + JobSet as failed. The JobSet is always declared failed if any job in the set finished with status failed. properties: maxRestarts: From acbafc8f5d4c38d7ffa211f5b3b2936edcbbd6c4 Mon Sep 17 00:00:00 2001 From: Daniel Vega-Myhre Date: Thu, 19 Oct 2023 00:54:27 +0000 Subject: [PATCH 2/2] update generated client code --- api/jobset/v1alpha2/openapi_generated.go | 2 +- hack/python-sdk/swagger.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/jobset/v1alpha2/openapi_generated.go b/api/jobset/v1alpha2/openapi_generated.go index 34edcfc41..e04da7d41 100644 --- a/api/jobset/v1alpha2/openapi_generated.go +++ b/api/jobset/v1alpha2/openapi_generated.go @@ -196,7 +196,7 @@ func schema_jobset_api_jobset_v1alpha2_JobSetSpec(ref common.ReferenceCallback) }, "failurePolicy": { SchemaProps: spec.SchemaProps{ - Description: "FailurePolicy, if set, configures when to declare the JobSet as failed. The JobSet is always declared failed if all jobs in the set finished with status failed.", + Description: "FailurePolicy, if set, configures when to declare the JobSet as failed. The JobSet is always declared failed if any job in the set finished with status failed.", Ref: ref("sigs.k8s.io/jobset/api/jobset/v1alpha2.FailurePolicy"), }, }, diff --git a/hack/python-sdk/swagger.json b/hack/python-sdk/swagger.json index 475fdc95c..ae3f181fa 100644 --- a/hack/python-sdk/swagger.json +++ b/hack/python-sdk/swagger.json @@ -76,7 +76,7 @@ "type": "object", "properties": { "failurePolicy": { - "description": "FailurePolicy, if set, configures when to declare the JobSet as failed. The JobSet is always declared failed if all jobs in the set finished with status failed.", + "description": "FailurePolicy, if set, configures when to declare the JobSet as failed. The JobSet is always declared failed if any job in the set finished with status failed.", "$ref": "#/definitions/jobset.v1alpha2.FailurePolicy" }, "network": {