Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate solution to CRD being too large to use kubectl apply #47

Closed
danielvegamyhre opened this issue Apr 19, 2023 · 1 comment · Fixed by #44
Closed

Investigate solution to CRD being too large to use kubectl apply #47

danielvegamyhre opened this issue Apr 19, 2023 · 1 comment · Fixed by #44

Comments

@danielvegamyhre
Copy link
Contributor

Currently the make install and make deploy commands won't work if the CRD / controller already exist on the cluster, since instead of doing kubectl apply they are both doing kubectl create now since the CRD is too large for kubectl apply as it runs into this issue.

I'm guessing this will be an unexpected user experience for users so we need to figure how will someone update their existing deployment without interruptions if only kubectl create works (implying they must delete then recreate). Alternatively, we need to figure out how to reduce the size of the CRD.

@ahg-g
Copy link
Contributor

ahg-g commented Apr 19, 2023

It seems doing server-side apply solves it: SeldonIO/seldon-core#4708

See how Kueue does it: https://github.com/kubernetes-sigs/kueue/blob/main/Makefile#L213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants