Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cert-manager with internal cert #52

Closed
Tracked by #43
danielvegamyhre opened this issue Apr 20, 2023 · 4 comments
Closed
Tracked by #43

Replace cert-manager with internal cert #52

danielvegamyhre opened this issue Apr 20, 2023 · 4 comments

Comments

@danielvegamyhre
Copy link
Contributor

danielvegamyhre commented Apr 20, 2023

We don't want a dependency on cert-manager and it also complicates the user experience by requiring they install it on their cluster beforehand. We should migrate to using internal certs.

See kubernetes-sigs/kueue#265 for example

@ahg-g
Copy link
Contributor

ahg-g commented Apr 23, 2023

It would be best to prioritize this and have it as part of 0.1.0 release.

@tenzen-y
Copy link
Member

Hello, jobset community :)

Do you plan to provide the component config like kueue to enable configurable cert settings such as whether the users use internal cert or cert-manager and so on?

https://github.com/kubernetes-sigs/kueue/blob/9ca57c86cf06c11a94a2d5b7badf60233a51a2f2/config/components/manager/controller_manager_config.yaml

@ahg-g
Copy link
Contributor

ahg-g commented Apr 24, 2023

Hello, jobset community :)

Do you plan to provide the component config like kueue to enable configurable cert settings such as whether the users use internal cert or cert-manager and so on?

https://github.com/kubernetes-sigs/kueue/blob/9ca57c86cf06c11a94a2d5b7badf60233a51a2f2/config/components/manager/controller_manager_config.yaml

Hello and welcome :)

Yes, for sure, do you mind opening an issue to track it?

@tenzen-y
Copy link
Member

Hello, jobset community :)
Do you plan to provide the component config like kueue to enable configurable cert settings such as whether the users use internal cert or cert-manager and so on?
https://github.com/kubernetes-sigs/kueue/blob/9ca57c86cf06c11a94a2d5b7badf60233a51a2f2/config/components/manager/controller_manager_config.yaml

Hello and welcome :)

Yes, for sure, do you mind opening an issue to track it?

Oh, sounds great!
I will create an issue, and I will help with introducing the component config to the JobSet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants