Deprovisioning Logging "replacement" when doing "deletion"

[jonathan-innis]

Version

Karpenter Version: v0.27.1

Kubernetes Version: v1.25.0

Expected Behavior

Karpenter should log "deprovisioning due to ... delete" when it is deleting a machine and not bringing up a replacement machine. We should be able to determine this by looking at the number of replacements and determining if it's greater than 0 to do the logging based on replacement or deletion

Actual Behavior

karpenter-84659d4f58-k5wnw controller 2023-04-07T23:39:21.138Z	INFO	controller.deprovisioning	deprovisioning via expiration replace, terminating 1 machines ip-192-168-78-59.us-west-2.compute.internal/c6a.48xlarge/on-demand	{"commit": "672a832-dirty"}

This occurred when Karpenter was deleting a machine and whewn

Steps to Reproduce the Problem

1. Bring up nodes due to a deployment
2. Scale down nodes (don't have emptiness or consolidation enabled)
3. Set .spec.ttlSecondsUntilExpaired to trigger expiration on nodes
4. View nodes being expired due to deletion but still logging replacement within the controller logs

Resource Specs and Logs

N/A

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment