Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewPDBLimits fails in 1.25+ k8s #85

Closed
Noksa opened this issue Nov 24, 2022 · 1 comment
Closed

NewPDBLimits fails in 1.25+ k8s #85

Noksa opened this issue Nov 24, 2022 · 1 comment

Comments

@Noksa
Copy link
Contributor

Noksa commented Nov 24, 2022

If we try to use karpenter-core on k8s 1.25+ we encouter the following problem when a new node is provisioned:

2022-11-24T08:53:42.773Z	ERROR	controller	Reconciler error	{"controller": "inflightchecks", "controllerGroup": "", "controllerKind": "Node", "Node": {"name":"kazoo5-first-db-kazoo5-first-couchdb-kazoodb-9ef87341"}, "namespace": "", "name": "kazoo5-first-db-kazoo5-first-couchdb-kazoodb-9ef87341", "reconcileID": "2720caef-d6e2-4802-88b6-9ef9693a4e7c", "error": "no matches for kind \"PodDisruptionBudget\" in version \"policy/v1beta1\""}

Reason: https://kubernetes.io/blog/2022/04/07/upcoming-changes-in-kubernetes-1-24/#looking-ahead (v1beta1 has been removed)

It looks like the problem is in this place: https://github.com/aws/karpenter-core/blob/23060db5957f34c547dd8d28c8653482fa3a396a/pkg/controllers/deprovisioning/pdblimits.go#L40

Actually it is policyv1 "k8s.io/api/policy/v1beta1"

I would suggest to fetch stable v1 policy first and if there is no such kind, fallback to v1beta1.

Thanks.

@ellistarn
Copy link
Contributor

See: aws/karpenter-provider-aws#2354

@Noksa Noksa closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants