Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Karpenter NoSchedule taint design #585

Merged
merged 4 commits into from
Oct 12, 2023
Merged

docs: add Karpenter NoSchedule taint design #585

merged 4 commits into from
Oct 12, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 10, 2023

Fixes #N/A

Description
As described in the design, there are some issues with Karpenter's use of the node.kubernetes.io/unschedulable taint. This proposes changing the taint to a karpenter specific taint.

How was this change tested?
N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner October 10, 2023 17:10
jonathan-innis
jonathan-innis reviewed Oct 10, 2023
View reviewed changes
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
designs/no-schedule-taint.md Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6472572428

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 81.814%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/topology.go 2 86.49%
pkg/controllers/provisioning/scheduling/topologygroup.go 2 96.75%
pkg/test/cachesyncingclient.go 2 80.21%
Totals Coverage Status
Change from base Build 6466099147: -0.06%
Covered Lines: 8930
Relevant Lines: 10915
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6472572428

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 81.851%
Files with Coverage Reduction New Missed Lines %
pkg/test/cachesyncingclient.go 2 80.21%
Totals Coverage Status
Change from base Build 6466099147: -0.02%
Covered Lines: 8934
Relevant Lines: 10915
💛 - Coveralls

@njtran njtran mentioned this pull request Oct 10, 2023
Merged
@coveralls
Copy link

coveralls commented Oct 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6500774081

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.195%
Totals Coverage Status
Change from base Build 6500425875: 0.0%
Covered Lines: 9039
Relevant Lines: 10997
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 552d312 into kubernetes-sigs:main Oct 12, 2023
6 checks passed
@njtran njtran deleted the noschedule branch December 26, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njtran @coveralls @jonathan-innis