-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg/cluster/internal/providers): log container init #3576
base: main
Are you sure you want to change the base?
Conversation
Add debug log of container nodes' init when verbosity is set to 5. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxgio92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @maxgio92! |
Hi @maxgio92. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What it introduces
This PR proposes to log all the container logs from before init, when setting the maximum verbosity supported.
Why is needed
This is extremely helpful to debug at runtime with logs from init and before, without the need to read individual logs afterward with export logs.
A lot of points can go wrong e.g. when setting up cgroups and in that case logs from Systemd are essential.
Combining them with logs from kind itself first and from Kubernetes then in a single output can be vital to better understand at runtime the initialization sequence of the containerized nodes, and possibly debug and resolve issues.
Closes #3575