From b038ea8a3c6a6e279876a6856553cfadf20cc71d Mon Sep 17 00:00:00 2001 From: Luis Sanchez Date: Tue, 17 Mar 2020 16:51:23 -0400 Subject: [PATCH] code review --- manifests/migrator.yaml | 1 - manifests/namespace-rbac.yaml | 33 +-------------------------------- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/manifests/migrator.yaml b/manifests/migrator.yaml index 55cc43e4a..9e92711ff 100644 --- a/manifests/migrator.yaml +++ b/manifests/migrator.yaml @@ -15,7 +15,6 @@ spec: labels: app: migrator spec: - serviceAccountName: storage-version-migration-migrator-sa containers: - name: migrator image: REGISTRY/storage-version-migration-migrator:VERSION diff --git a/manifests/namespace-rbac.yaml b/manifests/namespace-rbac.yaml index e61df6a93..b3a5589ce 100644 --- a/manifests/namespace-rbac.yaml +++ b/manifests/namespace-rbac.yaml @@ -17,18 +17,6 @@ rules: --- kind: ClusterRole apiVersion: rbac.authorization.k8s.io/v1 -metadata: - name: storage-version-migration-migrator -rules: -- apiGroups: ["*"] - resources: ["*"] - verbs: ["get", "list", "update"] -- apiGroups: ["migration.k8s.io"] - resources: ["storageversionmigrations"] - verbs: ["watch"] ---- -kind: ClusterRole -apiVersion: rbac.authorization.k8s.io/v1 metadata: name: storage-version-migration-crd-creator rules: @@ -55,7 +43,7 @@ subjects: namespace: NAMESPACE roleRef: kind: ClusterRole - name: storage-version-migration-migrator + name: cluster-admin apiGroup: rbac.authorization.k8s.io --- kind: ClusterRoleBinding @@ -96,22 +84,3 @@ roleRef: kind: ClusterRole name: storage-version-migration-initializer apiGroup: rbac.authorization.k8s.io ---- -kind: ServiceAccount -apiVersion: v1 -metadata: - namespace: NAMESPACE - name: storage-version-migration-migrator-sa ---- -kind: ClusterRoleBinding -apiVersion: rbac.authorization.k8s.io/v1 -metadata: - name: storage-version-migration-migrator-sa -subjects: - - kind: ServiceAccount - name: storage-version-migration-migrator-sa - namespace: NAMESPACE -roleRef: - kind: ClusterRole - name: cluster-admin - apiGroup: rbac.authorization.k8s.io