-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mocks don't match current controller-runtime package #363
Comments
Looks like there's no linting or unit tests being run as a PR presubmit, aside from some KIND installation? |
@justinsb This is (at least part of) the problem I mentioned in controller-runtime compat. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What happened:
pkg/test/mocks/manager.go isn't up to date with the controller-runtime package marked in go.mod
What you expected to happen:
pkg/test/mocks/manager.go.Manager should implement the controller-runtime Manager interface that it is supposed to mock.
How to reproduce it (as minimally and precisely as possible):
Attempt to use NewValidator
Anything else we need to know?:
var _ manager.Manager = &Manager{}
line 48 inpkg/test/mocks/manager.go
doesn't compileEnvironment:
kubectl version
):cat /etc/os-release
):uname -a
):go version
):The text was updated successfully, but these errors were encountered: