Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for a way to allow a new emoji 🚀 #54

Closed
mjlshen opened this issue Sep 27, 2023 · 1 comment · Fixed by #55
Closed

Looking for a way to allow a new emoji 🚀 #54

mjlshen opened this issue Sep 27, 2023 · 1 comment · Fixed by #55

Comments

@mjlshen
Copy link
Contributor

mjlshen commented Sep 27, 2023

case strings.HasPrefix(title, ":sparkles:"), strings.HasPrefix(title, emojiFeature):
title = strings.TrimPrefix(title, ":sparkles:")
title = strings.TrimPrefix(title, emojiFeature)
prType = FeaturePR
case strings.HasPrefix(title, ":bug:"), strings.HasPrefix(title, emojiBugfix):
title = strings.TrimPrefix(title, ":bug:")
title = strings.TrimPrefix(title, emojiBugfix)
prType = BugfixPR
case strings.HasPrefix(title, ":book:"), strings.HasPrefix(title, emojiDocs):
title = strings.TrimPrefix(title, ":book:")
title = strings.TrimPrefix(title, emojiDocs)
prType = DocsPR
case strings.HasPrefix(title, ":seedling:"), strings.HasPrefix(title, emojiInfra):
title = strings.TrimPrefix(title, ":seedling:")
title = strings.TrimPrefix(title, emojiInfra)
prType = InfraPR
case strings.HasPrefix(title, ":warning:"), strings.HasPrefix(title, emojiBreaking):
title = strings.TrimPrefix(title, ":warning:")
title = strings.TrimPrefix(title, emojiBreaking)
prType = BreakingPR
case strings.HasPrefix(title, ":running:"), strings.HasPrefix(title, emojiInfraLegacy):
// This has been deprecated in favor of :seedling:
title = strings.TrimPrefix(title, ":running:")
title = strings.TrimPrefix(title, emojiInfraLegacy)
prType = InfraPR
currently maintains a hardcoded list of PR prefixes. In cluster-api, we use this GitHub action and would like to use a new emoji 🚀 to denote the PR as a release PR.

Is there interest in onboarding a new emoji into this GitHub Action, or alternatively I can look into submitting a PR to allow consumers of this GitHub Action to specify a list of additional emoji's that are allowed? The benefits of this approach would be that we do not force other users of this GitHub Action to also accept the 🚀 emoji.

@furkatgofurov7
Copy link
Member

@vincepri @camilamacedo86 @varshaprasad96 hey folks sorry for tagging directly, but can someone take a look at the above request and help taking it further if it makes sense to you? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants